Repository navigation
feat(gif): show local packs as tiles that open in the picker - #863
Merged
Merged
Conversation
- With a provider that reports CAP_PACKS, a kind shows its pack tiles first, then the items without a pack. Tapping a tile opens the pack and a bar with a close button replaces the kind tabs. - Closing restores the previous list and scroll position. Searching leaves the pack and covers the whole kind. - If packs can't be listed, items are shown flat as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shows the GIF plugin's local packs in the keyboard picker, like the plugin's own category view.
CAP_PACKS, a kind (Stickers, Memes, ...) lists its pack tiles first (cover + "Name (count)"), then the items without a pack.listPacksfails or times out, items are shown flat as before. Providers withoutCAP_PACKS(GIPHY, KLIPY, older plugins) take the old path.listPacks/getPackAIDL calls, no contract version change.Contract.ktgains a doc comment only (kept identical to the plugin copy).Needs LeanBitLab/LeanType-Gif-Plugin#5 for packs to appear; works unchanged with older plugins.
Strings:
gif_pack_closeauto-translated (packaging-sense translations corrected by hand),gif_pack_labelis a format-only string markedtranslatable="false".Verified:
./gradlew :app:assembleStandardDebug, tested on device with the debug plugin (pack tiles, open/close, search, Memes/Recent tabs), logcat clean.